fix: 941 - respect rate-limits during integration tests #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `too_many_requests_exception.dart`: Exception when the server returns "Too many requests". * `too_many_requests_manager.dart`: Manager dedicated to "too many requests" server response. Deleted files: * `api_get_to_be_completed_products_test.dart`: moved "searchProduct" code to `api_search_products_test` * `api_get_user_products_test.dart`: moved "searchProduct" code to `api_search_products_test` * `api_matched_product_v2_test.dart`: moved "searchProduct" code to `api_search_products_test` Impacted files: * `api_get_localized_product_test.dart`: now using the `TooManyRequestsManager` for "getProduct" queries * `api_get_product_image_ids_test.dart`: now using the `TooManyRequestsManager` for "getProduct" queries * `api_get_product_test.dart`: moved "searchProduct" code to `api_search_products_test`; now using the `TooManyRequestsManager` for "getProduct" queries * `api_json_to_from_test.dart`: now using the `TooManyRequestsManager` for "getProduct" queries * `api_matched_product_v1_test.dart`: now using the `TooManyRequestsManager` for "getProduct" queries * `api_not_food_get_product_test.dart`: now using the `TooManyRequestsManager` for "getProduct" queries * `api_ocr_ingredients_test.dart`: now using the `TooManyRequestsManager` for "getProduct" queries * `api_search_products_test.dart`: now using the `TooManyRequestsManager` for "searchProducts" queries; moved code there from other test files, gathering all "searchProducts" queries here * `get_locations_order.dart`: unrelated minor improvement * `get_proofs_order.dart`: unrelated minor improvement * `open_food_api_client.dart`: now checking for `TooManyRequestsException`s for "getProduct" and "searchProducts" queries * `openfoodfacts.dart`: added the 2 new files
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #943 +/- ##
==========================================
- Coverage 76.34% 75.44% -0.91%
==========================================
Files 239 248 +9
Lines 8494 9027 +533
==========================================
+ Hits 6485 6810 +325
- Misses 2009 2217 +208 ☔ View full report in Codecov by Sentry. |
g123k
approved these changes
Jul 7, 2024
|
Thank you @g123k for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes bug(s)
Files
New files:
too_many_requests_exception.dart: Exception when the server returns "Too many requests".too_many_requests_manager.dart: Manager dedicated to "too many requests" server response.Deleted files:
api_get_to_be_completed_products_test.dart: moved "searchProduct" code toapi_search_products_testapi_get_user_products_test.dart: moved "searchProduct" code toapi_search_products_testapi_matched_product_v2_test.dart: moved "searchProduct" code toapi_search_products_testImpacted files:
api_get_localized_product_test.dart: now using theTooManyRequestsManagerfor "getProduct" queriesapi_get_product_image_ids_test.dart: now using theTooManyRequestsManagerfor "getProduct" queriesapi_get_product_test.dart: moved "searchProduct" code toapi_search_products_test; now using theTooManyRequestsManagerfor "getProduct" queriesapi_json_to_from_test.dart: now using theTooManyRequestsManagerfor "getProduct" queriesapi_matched_product_v1_test.dart: now using theTooManyRequestsManagerfor "getProduct" queriesapi_not_food_get_product_test.dart: now using theTooManyRequestsManagerfor "getProduct" queriesapi_ocr_ingredients_test.dart: now using theTooManyRequestsManagerfor "getProduct" queriesapi_search_products_test.dart: now using theTooManyRequestsManagerfor "searchProducts" queries; moved code there from other test files, gathering all "searchProducts" queries hereget_locations_order.dart: unrelated minor improvementget_proofs_order.dart: unrelated minor improvementopen_food_api_client.dart: now checking forTooManyRequestsExceptions for "getProduct" and "searchProducts" queriesopenfoodfacts.dart: added the 2 new files